Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Avoid a class of unhelpful accepted format drop downs. #19241

Merged

Conversation

jmchilton
Copy link
Member

Users do not know what 'data' means and displaying a drop down that just displays 'data' is unhelpful. If 'data' is in the list of accepted formats - the tool accepts anything so we don't need to mention any restrictions. The alternative here is a message that says - this inputs accepts datasets of any datatype - I can add that instead if we'd prefer.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Open a tool that does not restrict dataset extensions or a workflow input that doesn't and check that the message is gone.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review December 3, 2024 19:59
@github-actions github-actions bot added this to the 25.0 milestone Dec 3, 2024
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Having no extensions listed is better than just "data". 👍

@ahmedhamidawan ahmedhamidawan modified the milestones: 25.0, 24.2 Dec 3, 2024
@ahmedhamidawan ahmedhamidawan merged commit ef82f8f into galaxyproject:release_24.2 Dec 3, 2024
30 checks passed
@jmchilton jmchilton added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants