[24.2] Various list of pairs builder usability fixes. #19248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jmchilton
force-pushed
the
list_pairs_usability
branch
from
8f985a3 to
072b209
Compare
jmchilton
added
the
release-testing-24.2
jmchilton
force-pushed
the
list_pairs_usability
branch
from
072b209 to
6d0305c
Compare
Disable the button and make it clear in the message it has to do with empty filters.
How is a shade of green so evocative of a time.
It results in hiding all the data and a scary red messages when the user did literally nothing wrong. I think this is single biggest issue - it makes it seem like you cannot just manually pair these quickly.
jmchilton
force-pushed
the
list_pairs_usability
branch
from
6d0305c to
0cc2bab
Compare
|
A lot of failing stuff but it looks all unrelated to me. |
ahmedhamidawan
approved these changes
Dec 6, 2024
client/src/components/Collections/PairedListCollectionCreator.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cognitive load of not needing to understand the filters if they don't work out is so much lower. Jumping into the component with wrong filters pre-configured and hiding your data is confusing, scary, and generally unpleasant I think.
How to test the changes?
(Select all options that apply)
License