Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Record implicitly converted dataset as input dataset #19301

Open
wants to merge 2 commits into
base: release_24.1
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 10, 2024

by fixing the converter's output dataset extension to the requested extension.

We don't need to wait for the galaxy.json collection, we know the exact
target type already. That fixes the retrieval in
get_converted_files_by_type.

I believe this was always the intention and is how it works if the
dataset already exists (i.e. on a re-run), and for all converters that
don't use galaxy.json The converter records the dataset that the user
chose, so there's no gap in the provenance either.

This somewhat addresses
galaxyproject/total-perspective-vortex#141
so you can (reliably) differetiate your rules on the input datatype
and filesize combination.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

which means we collect and store the converted dataset as the job input.

We don't need to wait for the galaxy.json collection, we know the exact
target type already. That fixes the retrieval in
`get_converted_files_by_type`.

I believe this was always the intention and is how it works if the
dataset already exists (i.e. on a re-run), and for all converters that
don't use galaxy.json The converter records the dataset that the user
chose, so there's no gap in the provenance either.

This somewhat addresses
galaxyproject/total-perspective-vortex#141
so you can (reliably) differetiate your rules on the input datatype
and filesize combination.
@mvdbeek mvdbeek force-pushed the implicit_dataset_as_input branch from f10ed72 to a75bca5 Compare December 11, 2024 11:28
@mvdbeek mvdbeek marked this pull request as ready for review December 11, 2024 11:29
@github-actions github-actions bot added this to the 24.1 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant