Support setting and displaying timezone with the core metrics plugin #19527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confused myself and spent too much time this morning looking at the zoneless time displayed under the core metrics for a job, hence this effort to clarify.
When the
timezone
metric param is unset the behavior remains the same as before. I wanted to get the local server timezone so that we could at least display the name/offset in this case, but doing so is non-trivial using the standard lib. We do have both dateutil (direct) and tzlocal (indirect) as dependencies, but only use dateutil in one place and I didn't want to add another use on a library we could easily rewrite out.For a global server like usegalaxy.org it makes sense to just set it to UTC imo.
How to test the changes?
(Select all options that apply)
License