Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Make k8s user and group ids overriddable per job #19568

Open
wants to merge 3 commits into
base: release_24.2
Choose a base branch
from

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Feb 8, 2025

Makes k8s user and group ids overridable per job, which was preventing some tools like ITs and data managers from running.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot changed the title Make k8s user and group ids overriddable per job [24.2] Make k8s user and group ids overriddable per job Feb 8, 2025
@github-actions github-actions bot added this to the 25.0 milestone Feb 8, 2025
@nuwang nuwang requested a review from afgane February 8, 2025 14:02
@nuwang nuwang force-pushed the overridable_k8s_user_group_ids branch 3 times, most recently from 9345e1c to 6b5fd3e Compare February 11, 2025 19:01
@nuwang nuwang force-pushed the overridable_k8s_user_group_ids branch from 6b5fd3e to 3090cef Compare February 11, 2025 19:05
Copy link
Contributor

@afgane afgane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in a dev env and works as expected now. The only potential addition would be to add an example somewhere of how to configure this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants