Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix collection load error handling #19585

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 11, 2025

We'd pass null to errorMessageAsString and that would result in an error message where none was required.
Fixes a bug @blankenberg reported.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Feb 11, 2025
@mvdbeek mvdbeek force-pushed the fix_collection_load_error_handling branch from 278cd89 to d2a1efd Compare February 11, 2025 12:07
We'd pass null to errorMessageAsString and that would result in an error
message where none was required.
@mvdbeek mvdbeek force-pushed the fix_collection_load_error_handling branch from d2a1efd to e34b3fb Compare February 11, 2025 12:13
@dannon dannon merged commit 8c986bc into galaxyproject:release_24.1 Feb 11, 2025
27 checks passed
@blankenberg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants