ease the usage of galaxy.yml in ansible

[lecorguille]

Using anchor, you just need to modify the galaxy.yml and the ansible-galaxy role will do the almost rest. Thus, it's easier to sync the galaxy.yml after an update to the instance!?

- name: galaxy server
  hosts: galaxy
  vars_files:
    - "{{ inventory_dir }}/group_vars/galaxy/main.yml"
    - "{{ inventory_dir }}/group_vars/galaxy/galaxy.yml"
  handlers:
    - name: Restart Galaxy
      supervisorctl:
        name: galaxy
        state: restarted
  pre_tasks:
    - name: Install Dependencies
      package:
        name: ['python-psycopg2', 'git', 'python-virtualenv', 'make']
  roles:
     - role: geerlingguy.pip
     - role: usegalaxy-eu.supervisor
     - role: galaxyproject.galaxy

[martenson]

the sample file is not directly modified but rather generated via https://github.com/galaxyproject/galaxy/blob/dev/Makefile#L94 from https://github.com/galaxyproject/galaxy/blob/dev/doc/source/admin/galaxy_options.rst

[lecorguille]

Damn! 😝
Ok, but before trying, imagine that I succeed, is it something that can be acceptable?

[jmchilton]

uwsgi has very particular YAML processing - I don't think this would work - would it?

[lecorguille]

@jmchilton It seems so!
It's what we done here: galaxy.yml and playbook_galaxy.yml

BTW, I didn't find the time yet to implement that using your procedure.

[mvdbeek]

@nuwang I thought you might have thoughts on this or advise for @lecorguille

[nuwang]

@mvdbeek Thanks for bringing this up. My thoughts on this now are that it would be strongly desirable to move the uwsgi config to a separate file as you found was possible last time, because it really isn't yaml and makes the galaxy config file unmodifiable programatically, which is a bad situation to be in. Since it's relatively less likely that someone has modified the defaults in uwsgi.yaml, I think that this could be done with comparatively less disruption. It works quite well in the k8s setup.

@lecorguille The issue that will cause this to fail is the difference in how yaml arrays are defined here:
link
And here:

galaxy/lib/galaxy/config/sample/galaxy.yml.sample

Line 45 in 43af978

static-map: /static/style=static/style/blue

The repeating static-map in the latter case is invalid yaml, and will cause only the last entry to be included when you use a yaml anchor.

The reason this works with ansible-galaxy is because it has special logic to convert the valid yaml to invalid yaml that uwsgi understands:
https://github.com/galaxyproject/ansible-galaxy/blob/f450af8a6b8ad5c7c400603f4eed135810c8d81f/filter_plugins/uwsgi_yaml.py#L55

And even the libyaml version of uwsgi still doesn't use valid yaml: unbit/uwsgi#2097
so this is unlikely to be resolved in the short run.

Instead, what if you modify this line to use a jinja2 combine instead of a yaml anchor? That way, you might still be able to do what you're proposing (which is very useful) without needing to modify the sample config at all.

[mvdbeek]

Given @nuwang's suggestion I'm going to close this one, but thanks for this nice idea @lecorguille!