[19.09] Fix data_manager_manual with new data tables + cleanup and fixes #8817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
dmfix1909
branch
4 times, most recently
from
4c78302 to
6bed265
Compare
mvdbeek
changed the title
|
I think this is ready for review now. |
nsoranzo
reviewed
Oct 22, 2019
nsoranzo
reviewed
Oct 22, 2019
|
@mvdbeek here are now some conflicts. |
This is needed in case data_manager_manual should create a new data table.
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
jmchilton
approved these changes
Oct 23, 2019
nsoranzo
reviewed
Oct 23, 2019
| @@ -520,7 +520,6 @@ def tool_shed_repository(self): | |||
| name=self.repository_name, | |||
| owner=self.repository_owner, | |||
| installed_changeset_revision=self.installed_changeset_revision, | |||
| repository_id=self.repository_id, | |||
There was a problem hiding this comment.
Not sure I understand this change.
There was a problem hiding this comment.
If you specify a repository_id we'll not be able to use ToolConfRepository items, which don't have an id. We should only provide the repository_id when working in the galaxy_install module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #8792 by @abretaud