Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elixir toolkit theme to CoDex #237

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

supernord
Copy link
Collaborator

@bebatut / @paulzierep - could you please review? 😄

Completed:

Still to do:

  • Update column names (based on changes during the hackathon)
  • Update contributors list (CONTRIBUTORS.yml)
  • Create custom folder for deployment of website, which is separate to /docs
  • Merge columns and improve usability
  • Add tutorial and workflow tables
  • Add the ability to create community-specific tables that are subsets of the main CoDex

@paulzierep
Copy link
Collaborator

  • Need to check with @bedroesb to add SearchBuilder Requires DateTime when used with dates.
  • The servers got a 1 at the end

@supernord
Copy link
Collaborator Author

Thanks @paulzierep
@mthang found a solution to the DateTime issue
The number at the end is the value associated with each availability key in the metadata - suggestions for how to present this in the table? another column?

@supernord
Copy link
Collaborator Author

@paulzierep - do you think the date / time issue is being caused by the date being a string value?
e.g. in the tools.yml file the value is '2024-11-11'

@paulzierep
Copy link
Collaborator

I think: SearchBuilder Requires DateTime when used with dates means that the JS needs a DateTime package which is not there in the Elixir Toolkit, I asked @bedroesb to add it to the toolkit feature: ELIXIR-Belgium/elixir-toolkit-theme#292
Hope that solves it.

@paulzierep
Copy link
Collaborator

@supernord can you rebuild the website and check if the library works now, see: ELIXIR-Belgium/elixir-toolkit-theme#292

@bedroesb
Copy link

Tried it out locally. It should work now. I would suggets to add toc: false to the fronmatter of the md:

---
title: Tools
description: An interactive list of Galaxy tools created by the Galaxy CoDex.
datatable: true
sidebar: false
toc: false
---

This will prevent the table from jumping around after load.

I would also docs/_site in the .gitignore file to make it easier for local deployments.

@supernord
Copy link
Collaborator Author

thanks @bedroesb - that fixed the issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants