Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically switch to non-sample galaxy.yml if it exists #39

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 9, 2022

Should fix the issue @dannon ran into with Galaxy continuing to start up from galaxy.yml.sample

@mvdbeek mvdbeek requested a review from natefoo March 9, 2022 17:05
Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mvdbeek mvdbeek merged commit 761f5d0 into galaxyproject:main Mar 14, 2022
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 24, 2022

Hmm, that doesn't actually rewrite the supervisor config, unless you make an additional change in the gravity section of the config. That's a tricky one.

@natefoo
Copy link
Member

natefoo commented Mar 24, 2022

Even if you galaxyctl update?

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 24, 2022

With --force, yes, but that's not a good user experience. If they run run.sh they probably don't even know about gravity.

@natefoo
Copy link
Member

natefoo commented Mar 24, 2022

run.sh could do a galaxyctl update but yeah, it should not need --force.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants