Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processes in the handling dict in the job conf dict is a dict, not a list #60

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Jun 15, 2022

Should fix the test error in galaxyproject/galaxy#13995:

Traceback (most recent call last):
1056
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gravity/commands/cmd_register.py", line 18, in cli
1057
    cm.add(config)
1058
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gravity/config_manager.py", line 418, in add
1059
    conf = self.get_config(config_file, defaults=defaults)
1060
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gravity/config_manager.py", line 143, in get_config
1061
    for service_name in [x["service_name"] for x in ConfigManager.get_job_config(job_config) if x["service_name"] not in webapp_service_names]:
1062
  File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gravity/config_manager.py", line 212, in get_job_config
1063
    for handler_name, handler_options in processes.items():
1064
AttributeError: 'list' object has no attribute 'items'

@natefoo natefoo force-pushed the fix-default-processes-type branch from 793e2e9 to 942eeb4 Compare June 15, 2022 23:51
@natefoo natefoo force-pushed the fix-default-processes-type branch from 942eeb4 to 61fae28 Compare June 15, 2022 23:53
@nsoranzo nsoranzo merged commit 9d84195 into galaxyproject:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants