Drop most of the usage of configstate #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefoo
force-pushed
the
stateless-update
branch
from
76916cd to
b4addd9
Compare
|
I have created a new branch for this as I'd like to continue to iterate on the 0.x branch for the rest of 22.05, and this will for the basis of Gravity 1.0 for the 22.09 or 23.0 version of Galaxy. |
yeah that feels not unreasonable. |
natefoo
force-pushed
the
stateless-update
branch
from
b4addd9 to
e7f7e28
Compare
dir to $PATH if the gx-it-proxy is enabled.
If virtualenv is set in the Gravity config, automatically add its bin dir to $PATH if the gx-it-proxy is enabled
compare with existing configs to determine if changes are needed. Removes the need for configstate other than path to registered configs.
stored state handling.
used by Old Gravity™ many years ago and is incredibly unlikely to exist in the wild.
natefoo
force-pushed
the
stateless-update
branch
from
e7f7e28 to
8af3d77
Compare
natefoo
force-pushed
the
stateless-update
branch
from
2054bb3 to
91dd7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 properties remain in the configstate in addition to the config file path:
config_type,instance_name, andgalaxy_root.This change removes the need for detecting changes between subsequent invocations of Gravity. When
updateis run, we just generate the new process manager (supervisor) configs based on parsing the current Galaxy config, write out any new or changed configs, and delete everything else. This should be all around simpler and less confusing, plus it fixes the "can't unset env vars" issue I mentioned in #56.This change will result in parsing at least
galaxy.ymland possibly your job config file on most invocations where that would generally only happen onadd/registerandupdatebefore, so that could be a bit slow on a heavily loaded system with slow i/o.This will be a bit trickier for systemd since our service units won't be in an isolated directory like they are with supervisor, but we might be able to get away with assuming we own everything named
/etc/systemd/system/galaxy-*.Draft momentarily until #68 is merged and I'll rebase that out, plus squash the first 2 commits where I added and removed a tempdir-based method for stateless updates.