-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support systemd as a process manager #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configs when removing "invalid" configs (e.g. when changing a config's PM from supervisor to systemd)
as root if not in systemd mode.
test_process_manager
manager tests, and fix.
the default, tests.
memory limits globally or on individual services.
odesn't actually exist, it's graceful()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, prefer "passing through"
galaxyctl exec
so that the service units (or supervisor configs, when using supervisor) don't have to be rewritten every time there is a change. Regardless of what PM you use, you can rungalaxyctl exec <service_name>
to just run one of the services in the foreground, and this is now the command written to the process manager configs. If you don't want Gravity to write your systemd/supervisor configs, you can just write your own that callgalaxyctl exec ...
as necessary. This makes us behave more like a "normal" project that just deals with execution, not deployment, in a command line tool.This change also pretty much removes the need for configstate. We should be able to remove it in the default case of a single config/instance of galaxy, e.g. if you set
$GALAXY_CONFIG_FILE
or a (new, not yet created) global-c
/--galaxy-config
option then we can just skip the configstate entirely.I have to remember how to update the docs, and create a corresponding PR in Galaxy to update the docs and document how to set
start_timeout
andstop_timeout
on handler defs.