-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration of gx-it-proxy to support path-based proxying #96
Added configuration of gx-it-proxy to support path-based proxying #96
Conversation
@@ -287,6 +287,7 @@ def __update_service(self, config_file, config, attribs, service, instance_conf_ | |||
"galaxy_infrastructure_url": attribs["galaxy_infrastructure_url"], | |||
"tusd": attribs["tusd"], | |||
"gx_it_proxy": attribs["gx-it-proxy"], | |||
"proxy_path_prefix": attribs["proxy_path_prefix"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need a corresponding gravity/process_manager/systemd change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hexylena You mean in the "systemd-pm" branch? As it is an alternative process manager, I suppose so. But I cannot find the other configs there and this is anyway a bit out of my league. This is anyway just to be able to override the default value which is put together from the galaxy config and which probably should suffice in the large majority of cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I thought that had been merged already, my mistake. Maybe @natefoo can provide pull this change in there eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can handle merging forward to 1.x
Since it runs via |
I see. Since the addition of the new parameter will break a non-updated |
That is a good point - I'll dig into this or ask one of the Node experts if there's a good solution. |
Ok, I think we're best off just doing this in Gravity. Instead of |
Part of solution for galaxyproject/galaxy#14690. To be synced with galaxyproject/gx-it-proxy#14 and galaxyproject/galaxy#15147.