Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration of gx-it-proxy to support path-based proxying #96

Conversation

sveinugu
Copy link
Contributor

@sveinugu sveinugu commented Dec 8, 2022

@@ -287,6 +287,7 @@ def __update_service(self, config_file, config, attribs, service, instance_conf_
"galaxy_infrastructure_url": attribs["galaxy_infrastructure_url"],
"tusd": attribs["tusd"],
"gx_it_proxy": attribs["gx-it-proxy"],
"proxy_path_prefix": attribs["proxy_path_prefix"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a corresponding gravity/process_manager/systemd change?

Copy link
Contributor Author

@sveinugu sveinugu Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hexylena You mean in the "systemd-pm" branch? As it is an alternative process manager, I suppose so. But I cannot find the other configs there and this is anyway a bit out of my league. This is anyway just to be able to override the default value which is put together from the galaxy config and which probably should suffice in the large majority of cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I thought that had been merged already, my mistake. Maybe @natefoo can provide pull this change in there eventually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can handle merging forward to 1.x

@natefoo
Copy link
Member

natefoo commented Mar 13, 2023

Superseded by #100, thanks @sveinugu!

@sveinugu
Copy link
Contributor Author

Superseded by #100, thanks @sveinugu!

Thanks @natefoo! Perhaps the required version of gx-proxy-it be set in galaxy and/or gravity, or is that now done?

@natefoo
Copy link
Member

natefoo commented Mar 14, 2023

Since it runs via npx, the proxy is installed in ~/.cache/_npx. If you remove that, or run npx clear-npx-cache that should cause it to be reinstalled at the latest version the next time it runs. We don't have a mechanism for pinning it currently, but we could possibly add one to Galaxy.

@sveinugu
Copy link
Contributor Author

sveinugu commented Mar 14, 2023

Since it runs via npx, the proxy is installed in ~/.cache/_npx. If you remove that, or run npx clear-npx-cache that should cause it to be reinstalled at the latest version the next time it runs. We don't have a mechanism for pinning it currently, but we could possibly add one to Galaxy.

I see. Since the addition of the new parameter will break a non-updated gx-it-proxy, one should probably somehow make sure that it is automatically updated when existing installations are updated, even if a version is not pinned. Is there anything that ensures this? The mechanism for updating is so obscure that I am afraid we will cause headaches for lots of admins otherwise.

@natefoo
Copy link
Member

natefoo commented Mar 17, 2023

That is a good point - I'll dig into this or ask one of the Node experts if there's a good solution.

@natefoo
Copy link
Member

natefoo commented Mar 17, 2023

Ok, I think we're best off just doing this in Gravity. Instead of npx gx-it-proxy ... we can do npx gx-it-proxy@0.0.5 ... and it will automatically update. I'll create a PR for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants