Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planemo serve: --host not utilised #1429

Closed
selten opened this issue Feb 9, 2024 · 1 comment
Closed

Planemo serve: --host not utilised #1429

selten opened this issue Feb 9, 2024 · 1 comment
Labels
bug

Comments

@selten
Copy link
Contributor

selten commented Feb 9, 2024

  • Operating system: Ubuntu 22.04 in Docker
  • Setup details: Planemo and Galaxy are both installed in a docker container, this container is ran to allow 'planemo serve', 'planemo test' etc. However, for planemo serve we set --host to 0.0.0.0 for accessing the container outside of Docker. In the newer versions of Galaxy (22.05, 23.0, etc.) this is not respected by planemo.
  • Steps to reproduce:
    1. Setup planemo
    2. Setup Galaxy >= 22.05
    3. Run planemo serve with --host
@mvdbeek mvdbeek added the bug label Feb 9, 2024
selten added a commit to selten/planemo that referenced this issue Feb 9, 2024
@selten
galaxyproject#1429 Allow --host parameter
80c7df2 
Don't set a static host when it is able to be provided by planemo, use the provided value if available
selten added a commit to selten/planemo that referenced this issue Feb 9, 2024
@selten
galaxyproject#1429 Fix syntax error
6142e83
mvdbeek added a commit that referenced this issue Feb 12, 2024
@mvdbeek
Merge pull request #1430 from selten/patch-1
ee6a41e 
#1429 Allow --host parameter
@mvdbeek
Copy link
Member

mvdbeek commented Feb 12, 2024

Should be fixed in #1430, thanks @selten!

@mvdbeek mvdbeek closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@selten @mvdbeek