Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run_tests.sh invocation #1099

Merged
merged 6 commits into from
Nov 24, 2020

Conversation

nsoranzo
Copy link
Member

Also:

  • Drop support for Python 3.5
  • Add support for Python 3.9
  • Rebuild docs

@nsoranzo
Copy link
Member Author

nsoranzo commented Nov 23, 2020

Depends on kislyuk/argcomplete#332 and a new argcomplete release on PyPI.

@nsoranzo
Copy link
Member Author

Ready for review!

BTW, it looks to me that all test jobs in .circleci/config.yml are already run in GitHub workflows, can we drop the file? @jmchilton

@jmchilton jmchilton merged commit 38227c1 into galaxyproject:master Nov 24, 2020
@jmchilton
Copy link
Member

There are a bunch of overlapping parameters to get more of these buggy tests working - I'd very much like to expand test coverage (more tests, more versions of Python, more versions of Galaxy, etc..) so I was working on trying to get those circleci tests working. I wouldn't delete the file - I'd like to keep working on it.

@jmchilton
Copy link
Member

Thanks so much for the fix!

@nsoranzo nsoranzo deleted the run_tests.sh_invocation_fix branch November 24, 2020 16:39
@nsoranzo nsoranzo mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants