Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR workflow: report deployment failure #5047

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jan 11, 2023

I have tested this successfully with

  • the standard merge and
  • squash merge

Note, rebase merge does not work .. so we would need to disable this in the settings. This might be a limitation of the action used to get the PR number, but I guess its difficult / impossible because SHAs don't match to the SHAs of the commits in the PR.

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bernt-matthias
Copy link
Contributor Author

Thanks @bgruening .. I disabled the rebase merge option in the repo settings.

.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@nsoranzo nsoranzo merged commit 8980d85 into galaxyproject:main Jan 15, 2023
@nsoranzo nsoranzo deleted the report-deploy-fail branch January 15, 2023 12:20
bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants