Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bam2fastx outputs #5907

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 25, 2024

The outputs were never going to be produced. Together with galaxyproject/galaxy#17829 we ended up with passing tests when they should have failed.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

The outputs were never going to be produced. Together with galaxyproject/galaxy#17829
we ended up with passing tests when they should have failed.
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump?

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 25, 2024

sure

@bernt-matthias bernt-matthias enabled auto-merge (squash) March 25, 2024 14:24
@bernt-matthias bernt-matthias merged commit c2e67f1 into galaxyproject:main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants