Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spapros #6191

Merged
merged 46 commits into from
Aug 25, 2024
Merged

Add Spapros #6191

merged 46 commits into from
Aug 25, 2024

Conversation

heylf
Copy link
Contributor

@heylf heylf commented Jul 29, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@heylf
Copy link
Contributor Author

heylf commented Jul 29, 2024

There is a TODO in selection.xml, where I was unsure how to handle the GALAXY_SLOTS.

tools/spapros/selection.xml Outdated Show resolved Hide resolved
tools/spapros/selection.xml Show resolved Hide resolved
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heylf! I just added some things to think about, not strictly necessary to implement. Let me know what you think.

tools/spapros/macros.xml Outdated Show resolved Hide resolved
tools/spapros/evaluation.xml Show resolved Hide resolved
tools/spapros/macros.xml Outdated Show resolved Hide resolved
tools/spapros/selection.xml Show resolved Hide resolved
tools/spapros/selection.xml Outdated Show resolved Hide resolved
@bgruening
Copy link
Member

This looks great. But we need to find a better way for the image tests:

Output out_png:  different than expected, difference (using diff):
( /tmp/tmpjbdm8nerplot_confusion_matrix_test2.png v. /tmp/tmpqico90tkplot_confusion_matrix_test2.png )
Binary data detected, not displaying diff

Using the newer asserts will help here :)

@heylf
Copy link
Contributor Author

heylf commented Aug 6, 2024

Sorry, it seemed to me I was not supposed to touch the ci and pr yaml with this PR so I reverted.

@heylf heylf mentioned this pull request Aug 9, 2024
5 tasks
@bgruening
Copy link
Member

@kostrykin it still does not work. Even with a new planemo release.

@bgruening
Copy link
Member

@heylf Output out_masked_dotplot_png: different than expected, difference (using diff):

Now you can remove the comparison to images, asserts are working

@kostrykin
Copy link
Contributor

@kostrykin it still does not work. Even with a new planemo release.

I have no clue why the new planemo release didn't solve it, but maybe @bernt-matthias knows?
After all, it was his PR: galaxyproject/planemo#1471

<has_image_height height="600" delta="2"/>
</assert_contents>
</output>
<output name="marker_out" ftype="tabular"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid and causing the tests to fail. If you add an assertion or a file to test against this should work. If that's the issue I would revert #6218 and check that that works as expected.

@@ -0,0 +1,11 @@
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what is that? Its now green, but this file looks wired.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the empty value for some rows? thats how it suppose to be.

@bgruening bgruening merged commit a773446 into galaxyproject:main Aug 25, 2024
12 checks passed
@bgruening
Copy link
Member

Thanks @heylf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants