-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spapros #6191
Add Spapros #6191
Conversation
There is a TODO in selection.xml, where I was unsure how to handle the GALAXY_SLOTS. |
tools/spapros/test-data/tl.rank_genes_groups.newton-cg.pbmc68k_reduced_300cells.h5ad
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heylf! I just added some things to think about, not strictly necessary to implement. Let me know what you think.
This looks great. But we need to find a better way for the image tests:
Using the newer asserts will help here :) |
Sorry, it seemed to me I was not supposed to touch the ci and pr yaml with this PR so I reverted. |
@kostrykin it still does not work. Even with a new planemo release. |
@heylf Now you can remove the comparison to images, asserts are working |
I have no clue why the new planemo release didn't solve it, but maybe @bernt-matthias knows? |
tools/spapros/selection.xml
Outdated
<has_image_height height="600" delta="2"/> | ||
</assert_contents> | ||
</output> | ||
<output name="marker_out" ftype="tabular"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not valid and causing the tests to fail. If you add an assertion or a file to test against this should work. If that's the issue I would revert #6218 and check that that works as expected.
@@ -0,0 +1,11 @@ | |||
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, what is that? Its now green, but this file looks wired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean the empty value for some rows? thats how it suppose to be.
Thanks @heylf |
FOR CONTRIBUTOR: