Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a proper tutorial on adding slides #4620

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add a proper tutorial on adding slides #4620

wants to merge 6 commits into from

Conversation

hexylena
Copy link
Member

@hexylena hexylena commented Jan 8, 2024

  • moved into own subtopic
  • better tutorial/slide deck titles
  • duplicates a lot of the basic markdown tutorial but that's fine, should be clearer for folks.

xref #4611

@hexylena hexylena marked this pull request as ready for review March 18, 2024 10:57
@hexylena hexylena requested a review from a team as a code owner March 18, 2024 10:57
Copy link
Member

@bebatut bebatut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hexylena for the doing it!!!
I put some comments. Hope they are useful

topics/contributing/faqs/navigating-to-a-new-tutorial.md Outdated Show resolved Hide resolved
- shiltemann
---

Once we have set up the infrastructure, we are ready to write a slide deck.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put a requirement first (e.g. Running the GTN website locally or Running the GTN website online using GitPod)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

>
{: .agenda}

The tutorial's content should be placed in the file `slides.html`. Its syntax and structure are simple, and will have the following structure:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be mentioned that the file should be in the tutorial folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they want to create slides only, we should add that they should create the tutorial folder first

The `slides.html` needs to start with some metadata at the top:

- `layout: tutorial_slides`: please keep the default unless
- `title`: title of the tutorial (it will appear on the tutorial page and the topic page)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the title of the slide deck is different from the title in a tutorial.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a resolution process which prefers the tutorial's title for the material, or the slide's if the tutorial is not present.

it is not an optimal solution, but as long as tutorial + slides are mixed as a "material", I do not think we can find a better one.

The `slides.html` needs to start with some metadata at the top:

- `layout: tutorial_slides`: please keep the default unless
- `title`: title of the tutorial (it will appear on the tutorial page and the topic page)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say "tutorial" here or something else to point out to the slides?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not, you're right, it should say slides.

- userZ
```

To define a funding body in the `CONTRIBUTORS.yaml` there are a few extra fields available:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not FUNDERS.yaml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a point 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To define a funding body in the `CONTRIBUTORS.yaml` there are a few extra fields available:
To define a funding body in the `FUNDERS.yaml` there are a few extra fields available:


Please see the [associated slide deck]({% link topics/contributing/tutorials/create-new-tutorial-slides/slides.html %}) for details on the formatting commands available. In general the markdown you already know will continue to work, but there are additional slide formatting commands available (e.g. `.pull-left[]` for classic two column layouts.)

## Automated Video Recordings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this section after the Content section


## Adding images with captions

To add an image in Markdown file, we need to use the markdown syntax for this: {% raw %}`!​[proper alt text describing the image for visually impaired learners](../../images/image.png)`{% endraw %}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe mention where to store the image

```
{% endraw %}

### Guidelines on Alt vs Figcaption Text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section, the one before, and following ones look similar to the ones in "Tutorial" tutorial. Maybe we could put them in external Markdown and import them in both tutorials

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it would be a good FAQ. I am often linking to it when reviewing tutorials

@hexylena
Copy link
Member Author

Thanks for the review @bebatut these are all super helpful.

note for myself: document the math changes from #4611

Co-authored-by: Bérénice Batut <bebatut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants