Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX ColumnKernelizer for newer sklearn versions #54

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

mvdoc
Copy link
Collaborator

@mvdoc mvdoc commented Mar 28, 2024

Fixing issue related to sklearn change in 1.4: scikit-learn/scikit-learn#27204

@mvdoc mvdoc changed the title FIX add kwargs to ColumnKernelizer._hstack for newer sklearn versions FIX ColumnKernelizer for newer sklearn versions Mar 28, 2024
@mvdoc
Copy link
Collaborator Author

mvdoc commented Mar 28, 2024

@TomDLT do you see any issues with these fixes?

Copy link
Collaborator

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mvdoc mvdoc merged commit a5c226d into gallantlab:main Mar 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants