Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #209 #216

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fixes #209 #216

merged 2 commits into from
Jun 14, 2024

Conversation

lesquoyb
Copy link
Contributor

Makes the cycle variable visible from the outside by adding the facet attribute + the getter

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@@ -108,6 +108,10 @@
name = IKeyword.RNG,
type = IType.STRING,
doc = @doc (RandomUtils.DOC)),
@variable (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 41.30% to 40.43%, threshold = 30.0%

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

@lesquoyb lesquoyb merged commit 80997c9 into 2024-06 Jun 14, 2024
6 checks passed
@lesquoyb lesquoyb deleted the fixes-209 branch July 8, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant