Cleanup of gama-server #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -257,7 +257,7 @@ static public String constructAbsoluteFilePathAlternate(final IScope scope, fina | |||
|
|
|||
| ex.addContext(file.getAbsolutePath()); | |||
| } | |||
| // We havent found the file, but it may not exist. In that case, the | |||
| // We haven't found the file, but it may not exist. In that case, the | |||
There was a problem hiding this comment.
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.08 to 4.93, threshold = 4
gama.headless/src/gama/headless/runtime/GamaHeadlessWebSocketServer.java
Show resolved
Hide resolved
| @@ -337,7 +337,7 @@ public IExperimentPlan retrieveExperimentPlan(final WebSocket socket, final IMap | |||
| "For " + map.get("type") + ", mandatory parameter is: " + ISocketCommand.EXP_ID, map, false)); | |||
| } | |||
| plan = getExperiment(socket_id, exp_id); | |||
| if (plan == null || plan.getAgent() == null || plan.getAgent().dead() || plan.getCurrentSimulation() == null) { | |||
| if (plan == null || plan.getAgent() == null || plan.getAgent().dead()) { | |||
There was a problem hiding this comment.
✅ Getting better: Complex Conditional
retrieveExperimentPlan decreases from 1 complex conditionals with 3 branches to 1 complex conditionals with 2 branches, threshold = 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172 and try to address a few other issues