Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #262 but also some clues for further improvements.
@AlexisDrogoul could you double check this one as there are some points that I think could be improved in this class but I'm not sure yet:
buildImage
method, but it is not returned, instead the ImageProvider that did generate it is returned and is then drawn with thedrawAsset
method. I think that this method is generating another bufferedimage but I'm not sure and it may depend on many factors (nature of the provider, facets of the layer/display etc.). I did a test it with a matrix that changed every cycle and compared the average cycle time with current method and with one were we return the buffered image and draw it with the methoddrawImage
instead: I noticed a slight improvement (around 10%) in the average cycle execution time but it may as well be normal variability in simulations and I didn't dig much more.