Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a potential NPE in network when closing an experiment #392

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lesquoyb
Copy link
Contributor

@lesquoyb lesquoyb commented Jan 6, 2025

In case the socket was null (no call to connect or an exception when trying to), gama would raise a NPE when closing the simulation, which breaks the UI.

@lesquoyb lesquoyb added 😱 Bug The issue reveals a bug in GAMA About Networking Concerns the network plugin and all network-related activities in GAMA labels Jan 6, 2025
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene

@lesquoyb lesquoyb merged commit d830126 into 2024-06 Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
About Networking Concerns the network plugin and all network-related activities in GAMA 😱 Bug The issue reveals a bug in GAMA
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant