-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Runner v0 - Reliable and trimmed down cloud runner #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 44.92% 54.69% +9.76%
==========================================
Files 51 62 +11
Lines 1487 1918 +431
Branches 259 316 +57
==========================================
+ Hits 668 1049 +381
- Misses 779 865 +86
+ Partials 40 4 -36
|
…age driven caching
davidmfinol
approved these changes
Apr 10, 2022
webbertakken
approved these changes
Apr 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work once again. A huge step forward!
This was referenced Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the minimum features to implement the promise of cloud runner fully either via the default parameters or via the extensible override parameters.
Release Status Changes
K8s support
unstable/development->experimental
You can in theory easily accomplish distributed caching via pull cache override for k8s in this release to make k8s a fully viable workflow for massive projects. Will be experimenting with some multi-shared read/write PVs from Rook in the next PR.
Cloud Runner General Support
experimental->preview
AWS implementation out of the box can handle massive projects with sensible parameters.
Preview phase of cloud runner
If accepted I will begin using tag releases to communicate stable releases for cloud runner.
cloud-runner-develop
will continue as the primary integration branch.The preview phase of the cloud runner release will represent:
Post preview I will explore warm-starts, diff-based runs, generic dependency startup/cleanup hooks, editor integration, extensible logging, gcp run, testing improvements (including tests for caching hit/miss specific performance tests) extensible logging, benchmarking (large reference project), better artifact handling, more explicit checking of build success to make it convenient to expose results into output and probably more...
When satisfied with the above cloud runner will progress to released/ga.
Other improvements
There is also a general refactoring to make cloud runner polished and shiny. For example: