Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline code styles #384

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Streamline code styles #384

merged 7 commits into from
Apr 11, 2022

Conversation

webbertakken
Copy link
Member

Changes

  • Make ESLint setup a bit more robust
  • Uninstall husky hooks

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@webbertakken webbertakken requested review from frostebite and davidmfinol and removed request for frostebite April 11, 2022 20:54
@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #384 (9cc66a4) into main (4be5d2d) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 9cc66a4 differs from pull request most recent head 1bf138d. Consider uploading reports for the commit 1bf138d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          62       62           
  Lines        1918     1918           
  Branches      316      316           
=======================================
  Hits         1049     1049           
  Misses        865      865           
  Partials        4        4           
Impacted Files Coverage Δ
src/model/android-versioning.ts 100.00% <ø> (ø)
src/model/build-parameters.ts 95.34% <ø> (ø)
src/model/cli/cli-functions-repository.ts 43.75% <ø> (ø)
src/model/cli/cli.ts 31.34% <ø> (ø)
src/model/cloud-runner/cloud-runner.ts 79.31% <ø> (ø)
...ner/providers/aws/aws-cloud-formation-templates.ts 14.28% <ø> (ø)
.../model/cloud-runner/providers/aws/aws-job-stack.ts 9.52% <0.00%> (ø)
...odel/cloud-runner/providers/aws/aws-task-runner.ts 8.03% <ø> (ø)
src/model/cloud-runner/providers/aws/index.ts 17.50% <ø> (ø)
src/model/cloud-runner/providers/k8s/index.ts 12.00% <ø> (ø)
... and 30 more

Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this warning:

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

Since we already yarn.lock, should we remove the package-lock.json file?

@webbertakken
Copy link
Member Author

I get this warning:

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

Since we already yarn.lock, should we remove the package-lock.json file?

Indeed. I've removed the json file again and created a test so it's not created again in the future.

@webbertakken webbertakken merged commit 5ae03df into main Apr 11, 2022
@webbertakken webbertakken deleted the streamline-code-styles branch April 11, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants