Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: builds for Unity versions less than 2019 fail #467

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

cabauman
Copy link
Contributor

@cabauman cabauman commented Oct 15, 2022

Changes

Discovered when the gameci/docker repo CI failed in this PR.

Assets/Editor/Editor/UnityBuilderAction/Input/AndroidSettings.cs(14,32): error CS0117: 'PlayerSettings.Android' does not contain a definition for 'useCustomKeystore'

It's complaining about the line added in this unity-builder commit on May 21st.

PlayerSettings.Android.useCustomKeystore = true;

useCustomKeystore was added in Unity 2019 which is why 2018 builds fail.

Might also be worth adding Unity 2018 to the CI version list to prevent regressions.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #467 (1ab54fe) into main (f054aaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files          66       66           
  Lines        2056     2056           
  Branches      353      385   +32     
=======================================
  Hits         1080     1080           
  Misses        972      972           
  Partials        4        4           

@webbertakken webbertakken merged commit 9f79830 into game-ci:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants