Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misc minor issues in image-environment-factory and windows docker #477

Merged

Conversation

AndrewKahr
Copy link
Member

Changes

  • Remove GITHUB_WORKSPACE from image-environment-factory.ts
  • Fix windows workdir path in docker run command

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #477 (40f4e3b) into main (2a32a9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   36.61%   36.61%           
=======================================
  Files          72       72           
  Lines        2734     2734           
  Branches      507      507           
=======================================
  Hits         1001     1001           
  Misses       1731     1731           
  Partials        2        2           
Impacted Files Coverage Δ
src/model/docker.ts 11.62% <ø> (ø)
src/model/image-environment-factory.ts 7.14% <ø> (ø)

@webbertakken webbertakken merged commit f03bee0 into game-ci:main Nov 22, 2022
@AndrewKahr AndrewKahr deleted the bug/image-param-extra-workspace branch December 12, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants