Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android updates for Windows and androidVersionCode output #478

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

AndrewKahr
Copy link
Member

Changes

  • Create android keystore on windows when available
  • Output android version code

Needs game-ci/documentation#349

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #478 (78f5a2e) into main (2a32a9d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   36.61%   36.58%   -0.03%     
==========================================
  Files          72       72              
  Lines        2734     2736       +2     
  Branches      507      507              
==========================================
  Hits         1001     1001              
- Misses       1731     1733       +2     
  Partials        2        2              
Impacted Files Coverage Δ
src/model/output.ts 66.66% <0.00%> (-33.34%) ⬇️

dist/platforms/windows/build.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs to resolve merge conflicts by pulling the main branch and rebuilding.

@AndrewKahr AndrewKahr marked this pull request as draft November 22, 2022 13:44
@AndrewKahr AndrewKahr marked this pull request as ready for review November 23, 2022 01:08
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@webbertakken webbertakken merged commit 5bd589e into game-ci:main Nov 23, 2022
@AndrewKahr AndrewKahr deleted the feature/windows-android-qol branch December 12, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants