Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect environment variables on macos runner #499

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

cseteram
Copy link
Contributor

@cseteram cseteram commented Feb 5, 2023

Changes

When building an android application using game-ci/unity-builder on macos runner, it seems that there are the following bugs. First, it doesn't install android module when installing Unity. Second, when androidTargetSdkVersion is given, it doesn't install the appropriate android platform tools, which leads to build failures or wrong targeted SDK version.

This PR resolves these bugs by changing the following:

  • Fix a typo in switch-case statement which determines editor's module to be installed.
  • Set JAVA_HOME and ANDROID_HOME when installing android SDK.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #499 (f764296) into main (28147e5) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   36.85%   36.85%           
=======================================
  Files          74       74           
  Lines        2890     2890           
  Branches      582      582           
=======================================
  Hits         1065     1065           
  Misses       1688     1688           
  Partials      137      137           

@cseteram
Copy link
Contributor Author

The first issue was fixed in #501, so I updated the PR :)

@davidmfinol davidmfinol merged commit f35829a into game-ci:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants