Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for androidExportType #506

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

davidmfinol
Copy link
Member

Changes

  • Add default value for androidExportType

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #506 (42dbdcf) into main (0efa185) will not change coverage.
The diff coverage is n/a.

❗ Current head 42dbdcf differs from pull request most recent head 346fabd. Consider uploading reports for the commit 346fabd to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   37.28%   37.28%           
=======================================
  Files          75       75           
  Lines        2934     2934           
  Branches      600      600           
=======================================
  Hits         1094     1094           
  Misses       1703     1703           
  Partials      137      137           

@davidmfinol davidmfinol merged commit f58ac29 into main Feb 14, 2023
@davidmfinol davidmfinol deleted the androidExportType branch February 14, 2023 07:25
@AndrewKahr
Copy link
Member

@davidmfinol Note this will cause a breaking change. The code is configured to prefer androidExportType over exportAndroidAppBundle. If you set a default for this now, anyone who hasn't set the parameter explicitly and is still using the old parameter will have an androidPackage built. I believe the issue that covered this preferred the appBundle parameter to be deprecated and later removed in v3. At that stage it would be ideal to add the default value.

@davidmfinol
Copy link
Member Author

@AndrewKahr Thanks for the catch! I'll revert the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants