Fix defaults #510
Merged
Fix defaults #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason to completely remove the |
3 tasks
|
I'm not sure exactly how inputs works. I'm relying on it not being defined to know whether to prioritize over the app bundle parameter. If '' counts as undefined then it can be added as default. |
|
@davidmfinol Is it preferred to have an empty string default? I can see about changing the logic to support that. |
|
I think it would be better to have to the empty string default, so that it is consistent with how we are defining all the other inputs. |
|
Should be aligned with the other inputs now @davidmfinol |
davidmfinol
approved these changes
Feb 14, 2023
|
|
3 tasks
davidmfinol
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
code of conduct