Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection code for setting buildAppBundle #512

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

AndrewKahr
Copy link
Member

Changes

  • Fix reflection code for setting buildAppBundle
  • Mark AndroidSettings class as static

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #512 (9e6a277) into main (7f2782d) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e6a277 differs from pull request most recent head bd4b559. Consider uploading reports for the commit bd4b559 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #512   +/-   ##
=======================================
  Coverage   37.28%   37.28%           
=======================================
  Files          75       75           
  Lines        2934     2934           
  Branches      600      600           
=======================================
  Hits         1094     1094           
  Misses       1837     1837           
  Partials        3        3           

Copy link
Member

@davidmfinol davidmfinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewKahr Can you check index.js.map? I think it shouldn't need any change any more.

@davidmfinol davidmfinol merged commit c7a5c06 into game-ci:main Feb 20, 2023
@AndrewKahr AndrewKahr deleted the fix-aab-build-script branch March 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants