Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Builds Status Badge #520

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Fix Builds Status Badge #520

merged 2 commits into from
Mar 4, 2023

Conversation

davidmfinol
Copy link
Member

Changes

  • Fix Builds Status Badge

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #520 (7070291) into main (ef38f5a) will not change coverage.
The diff coverage is n/a.

❗ Current head 7070291 differs from pull request most recent head a7f0ec1. Consider uploading reports for the commit a7f0ec1 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   37.13%   37.13%           
=======================================
  Files          75       75           
  Lines        2916     2916           
  Branches      590      590           
=======================================
  Hits         1083     1083           
  Misses       1830     1830           
  Partials        3        3           

Copy link
Member

@AndrewKahr AndrewKahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if windows and Mac build badges should be added too?
Other than that lgtm

@davidmfinol
Copy link
Member Author

Good point about windows and macs. Added those 2.

@davidmfinol davidmfinol merged commit 309d668 into main Mar 4, 2023
@davidmfinol davidmfinol deleted the davidmfinol-patch-2 branch March 4, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants