-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Updates #529
V3 Updates #529
Conversation
…sha is invalid. Thus by using HEAD we will version based on the checked out sha. Tested with PR, commits, and tags and was unable to reproduce any extra counting when comparing outputs between HEAD and explicit sha values regardless of detached head state.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 37.11% 36.97% -0.15%
==========================================
Files 77 77
Lines 3039 3032 -7
Branches 588 586 -2
==========================================
- Hits 1128 1121 -7
Misses 1908 1908
Partials 3 3
|
Hmm I believe cloud runner's pipeline should have run checks on this. Perhaps you can enable it? |
Does cloudrunner require secrets? If they do, they can't run on PR, only commits to main |
Changes
github.sha
on the runner. However, when pulling in other repos and running the action, it may not be referencing the correct commit on the repo. After testing, though, nothing appears to be broken so this in theory should work fine. (Fix Environment variable to disable git repo checks #417)dockerWorkspacePath
. (Fix Docker Build Path Problem #433)androidAppBundle
parameter in favor ofandroidExportType
.Checklist
code of conduct