Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Updates #529

Merged
merged 14 commits into from
Mar 28, 2023
Merged

V3 Updates #529

merged 14 commits into from
Mar 28, 2023

Conversation

AndrewKahr
Copy link
Member

Changes

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@AndrewKahr AndrewKahr changed the title Misc fixes V3 Updates Mar 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #529 (cf6b78d) into main (7abb3a4) will decrease coverage by 0.15%.
The diff coverage is 71.42%.

❗ Current head cf6b78d differs from pull request most recent head 7e32490. Consider uploading reports for the commit 7e32490 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   37.11%   36.97%   -0.15%     
==========================================
  Files          77       77              
  Lines        3039     3032       -7     
  Branches      588      586       -2     
==========================================
- Hits         1128     1121       -7     
  Misses       1908     1908              
  Partials        3        3              
Impacted Files Coverage Δ
src/model/build-parameters.ts 89.39% <ø> (ø)
src/model/docker.ts 11.36% <0.00%> (ø)
src/model/input.ts 90.59% <100.00%> (-0.39%) ⬇️
src/model/versioning.ts 94.94% <100.00%> (-0.11%) ⬇️

@frostebite
Copy link
Member

Hmm I believe cloud runner's pipeline should have run checks on this. Perhaps you can enable it?

@AndrewKahr
Copy link
Member Author

Does cloudrunner require secrets? If they do, they can't run on PR, only commits to main

@AndrewKahr AndrewKahr merged commit 3032a4a into game-ci:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants