Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS unity base path so that unity existence check works as intended #551

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

VioletXF
Copy link
Contributor

@VioletXF VioletXF commented Jul 27, 2023

Changes

  • Fix a bug that existsSync(this.unityHubExecPath) always returns false

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@VioletXF VioletXF marked this pull request as ready for review July 27, 2023 13:18
@VioletXF VioletXF force-pushed the fix/macos-unity-existence-check branch from 8ec6c21 to 7756278 Compare July 27, 2023 14:09
@VioletXF
Copy link
Contributor Author

force push: revert disabling -nographics (I just disabled this option for personal use and pushed by mistake. Sorry!)

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/model/platform-setup/setup-mac.ts Show resolved Hide resolved
src/model/platform-setup/setup-mac.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #551 (d20d952) into main (857a41e) will not change coverage.
The diff coverage is n/a.

❗ Current head d20d952 differs from pull request most recent head 7756278. Consider uploading reports for the commit 7756278 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #551    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      613      586    -27     
========================================
  Hits         1121     1121            
- Misses       1758     1908   +150     
+ Partials      153        3   -150     

see 38 files with indirect coverage changes

@webbertakken webbertakken merged commit 21da302 into game-ci:main Jul 27, 2023
@VioletXF VioletXF mentioned this pull request Jul 27, 2023
4 tasks
@webbertakken
Copy link
Member

I merged this but the pipeline in main is failing now.

@VioletXF
Copy link
Contributor Author

@webbertakken I pushed fixes on #552. Sorry for making failing work 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants