-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS) #556
Conversation
Small Question 😅 |
It's a great question. I think we probably should stop pushing images for them. The reason we haven't is that some of the rationale is brought up by a very small amount of people. And we miss things. You bringing it up is really much appreciated. I've created an issue for it game-ci/docker#220 |
Docker @ game-ci/docker#216 |
Of course! I'd like to help with development and I've yet to sit down on my PC to actually make PRs so until now I've only helped with already existing issues and PRs :D |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 36.97% 36.96% -0.02%
==========================================
Files 77 77
Lines 3032 3033 +1
Branches 623 637 +14
==========================================
Hits 1121 1121
- Misses 1758 1912 +154
+ Partials 153 0 -153
|
ef5d84a
to
649ac6e
Compare
649ac6e
to
94795b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In case you are interested in an example of how this can break things, I'm sharing this just FYI: I'm using a two year old custom image to generate docfx documentation, and the build fails when updating from v2 to v3. The error is a bit jarring, but I assume just updating the custom image should help. I'm not sure when I'll get to that, but I'll probably ask in Discord if I face any issues. |
Thanks for sharing that input @sbergen! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 👍
…-ci#556) * fix: resolution errors and vulnerability * feat: bump (major) docker image rolling tag * chore: bump major version * fix: up workflow node to lts * fix: conventions
…-ci#556) * fix: resolution errors and vulnerability * feat: bump (major) docker image rolling tag * chore: bump major version * fix: up workflow node to lts * fix: conventions
Changes
Checklist
code of conduct
a PR in the documentation repo)