Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS) #556

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Aug 15, 2023

Changes

  • This PR will change the rolling tag from v1 to v2. That means that it will always use the latest v2 docker image. This is a potentially breaking change, however we do not expect most people to experience problems with this upgrade.
  • Fixes a couple of vulnerabilities and a compilation error
  • Pin Volta versions (so that Volta users will automatically use the right versions of node and yarn)

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@webbertakken webbertakken changed the title Bump docker version (Ubuntu 22.04 LTS) BREAKING - Bump docker version (Ubuntu 22.04 LTS) Aug 15, 2023
@webbertakken webbertakken changed the title BREAKING - Bump docker version (Ubuntu 22.04 LTS) BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS) Aug 15, 2023
@github-actions
Copy link

Cat Gif

@EliasVal
Copy link
Contributor

Small Question 😅
Why are Unity versions that have reached EOL are still having tests ran with? 2018.x, 2019.x and 2020.x have reached their EOL's a long while back and I think that support should be dropped for versions that Unity doesn't support themselves

@webbertakken
Copy link
Member Author

Small Question 😅 Why are Unity versions that have reached EOL are still having tests ran with? 2018.x, 2019.x and 2020.x have reached their EOL's a long while back and I think that support should be dropped for versions that Unity doesn't support themselves

It's a great question. I think we probably should stop pushing images for them. The reason we haven't is that some of the rationale is brought up by a very small amount of people. And we miss things. You bringing it up is really much appreciated.

I've created an issue for it game-ci/docker#220

@webbertakken
Copy link
Member Author

Docker @ game-ci/docker#216
Docs @ game-ci/documentation#407

@EliasVal
Copy link
Contributor

It's a great question. I think we probably should stop pushing images for them. The reason we haven't is that some of the rationale is brought up by a very small amount of people. And we miss things. You bringing it up is really much appreciated.

I've created an issue for it game-ci/docker#220

Of course! I'd like to help with development and I've yet to sit down on my PC to actually make PRs so until now I've only helped with already existing issues and PRs :D
The first issue I'm gonna tackle is probably this one :)

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #556 (a728a40) into main (43e1280) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a728a40 differs from pull request most recent head 649ac6e. Consider uploading reports for the commit 649ac6e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   36.97%   36.96%   -0.02%     
==========================================
  Files          77       77              
  Lines        3032     3033       +1     
  Branches      623      637      +14     
==========================================
  Hits         1121     1121              
- Misses       1758     1912     +154     
+ Partials      153        0     -153     
Files Changed Coverage Δ
...l/cloud-runner/providers/k8s/kubernetes-storage.ts 10.90% <100.00%> (ø)
...oud-runner/providers/k8s/kubernetes-task-runner.ts 12.34% <100.00%> (ø)
src/model/image-tag.ts 48.88% <100.00%> (ø)

... and 36 files with indirect coverage changes

@EliasVal EliasVal mentioned this pull request Aug 21, 2023
4 tasks
Copy link
Member

@AndrewKahr AndrewKahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@webbertakken webbertakken merged commit a073719 into main Aug 22, 2023
33 checks passed
@webbertakken webbertakken deleted the bump-docker-version branch August 22, 2023 08:03
@sbergen
Copy link
Contributor

sbergen commented Aug 26, 2023

In case you are interested in an example of how this can break things, I'm sharing this just FYI:

I'm using a two year old custom image to generate docfx documentation, and the build fails when updating from v2 to v3. The error is a bit jarring, but I assume just updating the custom image should help. I'm not sure when I'll get to that, but I'll probably ask in Discord if I face any issues.

@webbertakken
Copy link
Member Author

Thanks for sharing that input @sbergen!

Copy link
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

BryanLeongMBG added a commit to MightyBear/unity-builder that referenced this pull request Sep 20, 2023
…-ci#556)

* fix: resolution errors and vulnerability

* feat: bump (major) docker image rolling tag

* chore: bump major version

* fix: up workflow node to lts

* fix: conventions
BryanLeongMBG added a commit to MightyBear/unity-builder that referenced this pull request Sep 20, 2023
…-ci#556)

* fix: resolution errors and vulnerability

* feat: bump (major) docker image rolling tag

* chore: bump major version

* fix: up workflow node to lts

* fix: conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants