Removed checks for old unity versions

[EliasVal]

Changes

Changed referenced EOL versions in tests to LTS and Current versions (2018.x-2020.x -> 2021.x-2023.x)

Checklist

• Read the contribution guide and accept the
  code of conduct
• Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
  a PR in the documentation repo)
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[EliasVal]

@webbertakken As promised :)
Let me know if any further changes are needed

[webbertakken]

Looks good to me.

Note that this is just the checks to make sure unity-builder works as expected. We'll still need to do the same for test-runner and other actions that use the images. game-ci/docker#220 is for changing the workflow to no longer even publish these images in the first place.

[codecov-commenter]

Codecov Report

Merging #558 (4db47bb) into main (5f78283) will not change coverage.
The diff coverage is n/a.

❗ Current head 4db47bb differs from pull request most recent head 6b85123. Consider uploading reports for the commit 6b85123 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main     #558    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      623      623            
========================================
  Hits         1121     1121            
- Misses       1758     1908   +150     
+ Partials      153        3   -150     

see 38 files with indirect coverage changes

[EliasVal]

We'll still need to do the same for test-runner and other actions that use the images.

@webbertakken So just change any reference to a version earlier than 2021.x to use 2022 LTS?

[webbertakken]

We'll still need to do the same for test-runner and other actions that use the images.

@webbertakken So just change any reference to a version earlier than 2021.x to use 2022 LTS?

Not sure I understand the question to be honest. Also we're supporting all non-EOL versions, not just LTS.

So basically what we have to do is stop publishing EOL images in the game-ci/docker repository (which is done in game-ci/versioning-backend I believe. And the usages of it, like here in builder like you did.

[webbertakken]

Which is to say you marked this PR as "resolves" the docker issue, but that is to stop publication of EOL images, not just usage. So we need to unlink that resolves-link.

[EliasVal]

Which is to say you marked this PR as "resolves" the docker issue, but that is to stop publication of EOL images, not just usage. So we need to unlink that resolves-link.

Sure, on it!

Not sure I understand the question to be honest. Also we're supporting all non-EOL versions, not just LTS.

So basically what we have to do is stop publishing EOL images in the game-ci/docker repository (which is done in game-ci/versioning-backend I believe. And the usages of it, like here in builder like you did.

What I meant here is, to change every field that references the EOL versions to 2022.x (2021.x is EOL in April so 2022.x gives us more headroom)

i.e game-ci/unity-test-runner/src/model/docker.test.ts, const image = '....2019.2.11f1...', to const image = '...2022.3.7f1....'

[webbertakken]

I see. Yes sounds good to me!