-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfixes for 4.2.0 #630
Hotfixes for 4.2.0 #630
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 36.97% 36.93% -0.04%
==========================================
Files 77 77
Lines 3116 3119 +3
Branches 605 608 +3
==========================================
Hits 1152 1152
- Misses 1964 1967 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Nice one.
I see there are some jobs failing. Not sure if it's related to current changes or if they're just flaky jobs 🤷
Saving job output here in case job logs expire:
Details
Run ./
with:
buildName: GameCI Test Build
projectPath: test-project
unityVersion: [2](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:2)02[3](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:3).2.2f1
targetPlatform: iOS
customParameters: -profile SomeProfile -someBoolean -someValue exampleValue
allowDirtyBuild: true
versioning: Semantic
androidExportType: androidPackage
androidSymbolType: none
runAsHostUser: false
dockerIsolationMode: default
containerRegistryRepository: unityci/editor
containerRegistryImageVersion: 3
awsStackName: game-ci
providerStrategy: local
kubeVolumeSize: 5Gi
watchToEnd: true
cacheUnityInstallationOnMac: false
dockerWorkspacePath: /github/workspace
skipActivation: false
env:
UNITY_EMAIL: ***
UNITY_PASSWORD: ***
UNITY_SERIAL: ***
(node:1236) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.
Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)
/bin/sh
57
57
Found semantic version [4](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:4).0.3 for skip-activation-bug@b6a[5](https://github.com/game-ci/unity-builder/actions/runs/7954027911/job/21710863347?pr=630#step:4:5)abb
Using android versionCode 4000003
Building locally
/usr/local/bin/brew install unity-hub
==> Downloading https://public-cdn.cloud.unity3d.com/hub/prod/UnityHubSetup.dmg
Warning: No checksum defined for cask 'unity-hub', skipping verification.
==> Installing Cask unity-hub
Warning: macOS's Gatekeeper has been disabled for this Cask
==> Moving App 'Unity Hub.app' to '/Applications/Unity Hub.app'
🍺 unity-hub was successfully installed!
Error: fetch failed
Ah, it looks like switching tests to pure il2cpp was a bit too greedy on tests as Linux can't build Windows il2cpp. I think what I'll do is still merge this PR and get the hotfix out to unbreak people's pipelines then fix the test workflow since that won't impact anyone else using the action. |
Sounds good 🚀 |
* Fix mac env variables not getting skip activation * Fix image tag for linux il2cpp. Force tests to use il2cpp * Scripting backend is always il2cpp
Changes
Checklist
code of conduct
in the documentation repo)