Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft #73

Conversation

Sparticuz
Copy link
Contributor

@Sparticuz Sparticuz commented Aug 26, 2022

@Sparticuz Sparticuz force-pushed the minecraft branch 2 times, most recently from 0807ddd to 6e36df3 Compare August 26, 2022 19:18
@zb140 zb140 deleted the branch games-on-whales:zb140/refactor-compose-files September 3, 2022 20:08
@zb140 zb140 closed this Sep 3, 2022
@zb140
Copy link
Contributor

zb140 commented Sep 3, 2022

Why does github think i closed this? It certainly wasn't on purpose...

@zb140
Copy link
Contributor

zb140 commented Sep 3, 2022

I didn't realize deleting my branch was going to close this. Apologies, @Sparticuz! Would you mind rebasing onto master?

@@ -2,3 +2,5 @@ local_state=./local_state

TIME_ZONE=Europe/London

# Set a gnome-keyring password
# KEYPASS=password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment: is this specific to the Minecraft container? If so, maybe it should go into env/minecraft.env. It doesn't exist yet, but run-gow will automatically pick it up if you create one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on vacation right now, but can rebase next week. It currently is only on this container, however, if gnome-keyring is reused on other containers it would need to be able to use the same password.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@zb140
Copy link
Contributor

zb140 commented Sep 4, 2022

One other thing I just thought of: you might want to edit .github/workflows/docker-build.yml to add this container to the build matrix.

@Sparticuz Sparticuz mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants