-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minecraft #73
Minecraft #73
Conversation
0807ddd
to
6e36df3
Compare
Why does github think i closed this? It certainly wasn't on purpose... |
I didn't realize deleting my branch was going to close this. Apologies, @Sparticuz! Would you mind rebasing onto master? |
@@ -2,3 +2,5 @@ local_state=./local_state | |||
|
|||
TIME_ZONE=Europe/London | |||
|
|||
# Set a gnome-keyring password | |||
# KEYPASS=password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment: is this specific to the Minecraft container? If so, maybe it should go into env/minecraft.env
. It doesn't exist yet, but run-gow
will automatically pick it up if you create one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on vacation right now, but can rebase next week. It currently is only on this container, however, if gnome-keyring is reused on other containers it would need to be able to use the same password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks!
One other thing I just thought of: you might want to edit |
Depends on #69
Just a note: The
gnome-keyring
stuff came from https://unix.stackexchange.com/questions/473528/how-do-you-enable-the-secret-tool-command-backed-by-gnome-keyring-libsecret-an