Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string.sub broken for j=0 or j<i #40

Open
fcr-- opened this issue May 17, 2017 · 1 comment
Open

string.sub broken for j=0 or j<i #40

fcr-- opened this issue May 17, 2017 · 1 comment

Comments

@fcr--
Copy link
Contributor

fcr-- commented May 17, 2017

string.sub('abcde', 4, 1) should be an empty string, not 'bc'.
string.sub('abcde', 3, 0) should be an empty string, not 'cde'.
fcr-- added a commit to fcr--/moonshine that referenced this issue May 17, 2017
@fcr--
Fix bug gamesys#40: string.sub broken for j=0 or j<i
18840e3
paulcuth pushed a commit that referenced this issue Jul 10, 2017
@fcr-- @paulcuth
Fix bug #40: string.sub broken for j=0 or j<i
d3f70d8
@bmcbarron
Copy link

This appears to be fixed on master, although moonshine.js and moonshine.min.js were not rebuilt in that CL. PR #46 includes a rebuild that incorporates those fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcr-- @bmcbarron