Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 219 no2 #240

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue 219 no2 #240

wants to merge 3 commits into from

Conversation

pdeiml
Copy link
Collaborator

@pdeiml pdeiml commented May 30, 2018

This is one way how to control which SED goes to the catalog.

If you look to input/gammacat/gamma_cat_sed.yaml and there at source_id = 1, you can see the idea:

  • source_id and status is nothing new
  • reference_id: all references where at least one sed-file of the source is stored
  • catalog:
    - reference_id: The reference_id of the sed which goes to the catalog
    - file_id: If there are more than one sed file, the file with file_id goes to the catalog (if there is only one file, the default value is -1)

I only want to introduce this idea of a schema and if it is agreed then one needs to add the keywords to all sources.

@cdeil
Copy link
Contributor

cdeil commented Jul 7, 2018

I would stronly prefer to only have one single config file for the catalog.
I.e. my suggestion would be to change this file
https://github.com/gammapy/gamma-cat/blob/master/input/gammacat/gamma_cat_dataset.yaml
to add the extra info, e.g. a sed_ref_id key.

@pdeiml
Copy link
Collaborator Author

pdeiml commented Jul 9, 2018

Ok, if we stay with one single file, then I would suggest to add three additional infos:
sed_ref_id
lc_ref_id
ds_ref_id (data set)

What do you think?

@cdeil
Copy link
Contributor

cdeil commented Jul 9, 2018

I would leave reference_id as-is, and optionally if there is reference_id_sed or reference_id_lc, use that for SED or LC (and otherwise default to use the same for all).
I.e. minimal edits to get what we want.

But either way, your more verbose, but also more explicit choice for each part of the catalog data is also good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants