Fix prebid#3813 move auctionEnd events so it always executes when auc…

…tion completes (prebid#3841) * move auctionEnd events so it always executes * remove some commented code
gamoshi · Nov 28, 2019 · e00a5fe · e00a5fe
1 parent 32d14d0
commit e00a5fe
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 14 deletions.
diff --git a/src/auction.js b/src/auction.js
@@ -140,7 +140,7 @@ export function newAuction({adUnits, adUnitCodes, callback, cbTimeout, labels, a
       clearTimeout(_timer);
     }
 
-    if (_callback != null) {
+    if (_auctionEnd === undefined) {
       let timedOutBidders = [];
       if (timedOut) {
         utils.logMessage(`Auction ${_auctionId} timedOut`);
@@ -150,17 +150,19 @@ export function newAuction({adUnits, adUnitCodes, callback, cbTimeout, labels, a
         }
       }
 
-      try {
-        _auctionStatus = AUCTION_COMPLETED;
-        _auctionEnd = Date.now();
-
-        events.emit(CONSTANTS.EVENTS.AUCTION_END, getProperties());
+      _auctionStatus = AUCTION_COMPLETED;
+      _auctionEnd = Date.now();
 
-        const adUnitCodes = _adUnitCodes;
-        const bids = _bidsReceived
-          .filter(utils.bind.call(adUnitsFilter, this, adUnitCodes))
-          .reduce(groupByPlacement, {});
-        _callback.apply($$PREBID_GLOBAL$$, [bids, timedOut]);
+      events.emit(CONSTANTS.EVENTS.AUCTION_END, getProperties());
+      try {
+        if (_callback != null) {
+          const adUnitCodes = _adUnitCodes;
+          const bids = _bidsReceived
+            .filter(utils.bind.call(adUnitsFilter, this, adUnitCodes))
+            .reduce(groupByPlacement, {});
+          _callback.apply($$PREBID_GLOBAL$$, [bids, timedOut]);
+          _callback = null;
+        }
       } catch (e) {
         utils.logError('Error executing bidsBackHandler', null, e);
       } finally {
@@ -175,7 +177,6 @@ export function newAuction({adUnits, adUnitCodes, callback, cbTimeout, labels, a
           syncUsers(userSyncConfig.syncDelay);
         }
       }
-      _callback = null;
     }
   }
 

diff --git a/test/spec/auctionmanager_spec.js b/test/spec/auctionmanager_spec.js
@@ -1,4 +1,4 @@
-import { getKeyValueTargetingPairs, auctionCallbacks } from 'src/auction';
+import { getKeyValueTargetingPairs, auctionCallbacks, AUCTION_COMPLETED } from 'src/auction';
 import CONSTANTS from 'src/constants.json';
 import { adjustBids } from 'src/auction';
 import * as auctionModule from 'src/auction';
@@ -783,7 +783,8 @@ describe('auctionmanager.js', function () {
         server.restore();
         events.emit.restore();
       });
-      it('should emit BID_TIMEOUT for timed out bids', function (done) {
+
+      it('should emit BID_TIMEOUT and AUCTION_END for timed out bids', function (done) {
         const spec1 = mockBidder(BIDDER_CODE, [bids[0]]);
         registerBidder(spec1);
         const spec2 = mockBidder(BIDDER_CODE1, [bids[1]]);
@@ -797,6 +798,12 @@ describe('auctionmanager.js', function () {
           const timedOutBids = bidTimeoutCall.args[1];
           assert.equal(timedOutBids.length, 1);
           assert.equal(timedOutBids[0].bidder, BIDDER_CODE1);
+
+          const auctionEndCall = eventsEmitSpy.withArgs(CONSTANTS.EVENTS.AUCTION_END).getCalls()[0];
+          const auctionProps = auctionEndCall.args[1];
+          assert.equal(auctionProps.adUnits, adUnits);
+          assert.equal(auctionProps.timeout, 20);
+          assert.equal(auctionProps.auctionStatus, AUCTION_COMPLETED)
           done();
         }
         auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: auctionCallback, cbTimeout: 20});