Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add runMonitoring #2344

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Re-add runMonitoring #2344

merged 9 commits into from
Jun 10, 2024

Conversation

mesmith75
Copy link
Contributor

Fixes #2340

@mesmith75 mesmith75 changed the title WIP: Re-add runMonitoring Re-add runMonitoring May 20, 2024
egede
egede reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@egede egede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I call runMonitoring when the monitoring is already running automatically. Will it do nothing, start a second parallel operation (and maybe cause trouble), do nothing, or make the whole thing crash?

@mesmith75
Copy link
Contributor Author

It does nothing

@mesmith75
Copy link
Contributor Author

This is ready for review.

@mesmith75 mesmith75 merged commit a676195 into develop Jun 10, 2024
8 of 10 checks passed
@mesmith75 mesmith75 deleted the runMonitoring_fix branch June 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderrichards alexanderrichards alexanderrichards approved these changes

@egede egede Awaiting requested review from egede

Assignees
No one assigned
Labels
aio monitoring service enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to monitor a slice
3 participants
@mesmith75 @egede @alexanderrichards