Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAP_FLAGS to list of inputs #24

Closed

Conversation

james-d-mitchell
Copy link

I wonder if it would be a good idea to check whether or not the inputs only-needed is true and GAP_FLAGS contains -A would be a good idea. I also haven't tested this at all, I'm not sure how to, hopefully there's some ci here?

@james-d-mitchell
Copy link
Author

@fingolfin

action.yml Outdated Show resolved Hide resolved
Co-authored-by: Wilf Wilson <wilf@wilf-wilson.net>
@wilfwilson
Copy link
Contributor

Hey @james-d-mitchell, thanks for this.

I'll mention #9 here to make it easy to reference, in which you mention that you'd particularly like this for loading/saving workspaces.

I've looked into this a little bit, and I feel a little bit out of the loop in how all of this actions stuff works right now (haven't looked at it for a long time).

So I'm not sure what the best thing to do is, so that your new GAP_FLAGS option works in the most sensible way (with respect to the other input options, and with respect to the GAP arguments that are already used). Perhaps @fingolfin has some ideas.

As of the current master branch, this workflow already may or may not (depending on the inputs to the workflow) set the GAP command line arguments -l, --quitonbreak, --cover, and -A, as you refer to.

I've put an example of how you could add some very rudimentary CI for this GAP_FLAGS in wilfwilson@ee44353 - hopefully you can see that and cherry-pick it or whatever.

@james-d-mitchell
Copy link
Author

Thanks @wilfwilson, if I understand correctly, what I was trying to add in this PR is already implemented, making this superfluous. I'll close the PR that being the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants