Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange release.txt file, also RELEASE.md? #93

Closed
fingolfin opened this issue Feb 25, 2023 · 2 comments
Closed

Strange release.txt file, also RELEASE.md? #93

fingolfin opened this issue Feb 25, 2023 · 2 comments

Comments

@fingolfin
Copy link
Member

There is a file release.txt which says this:

This major release includes multiple bug fixes and performance improvements.

We dropped support to jupyter notebooks extension.

So it looks as if this meant to be a kind of NEWS or CHANGES file. But then it should at the very least indicate which version it refers to (I'd suggest to also include the date that release was made).

At the same time there is a file RELEASE.md which despite its similar name seems to be totally unrelated, and serves as a reminder for @mcmartins . I would recommend to move that into a subdir dev or etc, and exclude it from the release tarball.

@mcmartins
Copy link
Member

Indeed, RELEASE.md was an old document used to describe the old release procedure that was relying on Travis to run all the steps. I'll remove it.
The release.txt is used by the job softprops/action-gh-release@v1 and serves as the github release body text.
I'll exclude these form the tarball

mcmartins added a commit that referenced this issue Feb 26, 2023
added new workflow for releasetools
mcmartins added a commit that referenced this issue Feb 27, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

---------

Co-authored-by: Manuel Martins <Manuel.Martins@ecmwf.int>
Co-authored-by: Jerry James <loganjerry@gmail.com>
mcmartins added a commit that referenced this issue Mar 2, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

---------

Co-authored-by: Manuel Martins <Manuel.Martins@ecmwf.int>
Co-authored-by: Jerry James <loganjerry@gmail.com>
mcmartins added a commit that referenced this issue Mar 10, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

---------

Co-authored-by: Manuel Martins <Manuel.Martins@ecmwf.int>
Co-authored-by: Jerry James <loganjerry@gmail.com>
mcmartins added a commit that referenced this issue Mar 10, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

* Update RELEASE.yml

---------

Co-authored-by: Manuel Martins <Manuel.Martins@ecmwf.int>
Co-authored-by: Jerry James <loganjerry@gmail.com>
mcmartins added a commit that referenced this issue Mar 14, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

* Update RELEASE.yml

* added fetch-depth: 0 to fetch all branches

---------

Co-authored-by: Manuel Martins <Manuel.Martins@ecmwf.int>
Co-authored-by: Jerry James <loganjerry@gmail.com>
mcmartins added a commit that referenced this issue Mar 14, 2023
* develop:
  update gh-pages branch
  added fetch-depth: 0 to fetch all branches
  Update RELEASE.yml
  Update RELEASE.yml
  new release 2.0.2 to test ReleaseTools
  workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)
  workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)
  use yarn instead of npm
  revert changes from latest jupyterlab extension cookiecutter
  fix for #92 #93 and #94 added new workflow for releasetools
  fixed package info
  fixed dockerfile for binder
  fixed dockerfile for binder
  fixed dockerfile for binder
  fixed workflows fixed dockerfile for binder
  Fix unknown entity warnings (#90)
  Canvas test failures #91 fixed workflows fixed dockerfile for binder
@mcmartins
Copy link
Member

I've removed both files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants