Skip to content

Commit

Permalink
Use TmpName instead of TmpNameAllArchs
Browse files Browse the repository at this point in the history
There are only differences between the two in older GAP versions, and
only in Cygwin. In recent GAP versions, the latter is just an alias for
the former, and `TmpNameAllArchs` has been deprecated. Indeed guava is
the last package still using it.
  • Loading branch information
fingolfin committed Jan 29, 2024
1 parent 42e3119 commit 1343183
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions lib/codeman.gi
Original file line number Diff line number Diff line change
Expand Up @@ -398,10 +398,10 @@ function(C, wt)
return CWS;
else
#Print("the C code programs are compiled, so using Leon's binary....\n");
incode := TmpNameAllArchs();
incode := TmpName();

Check warning on line 401 in lib/codeman.gi

View check run for this annotation

Codecov / codecov/patch

lib/codeman.gi#L401

Added line #L401 was not covered by tests
PrintTo( incode, "\n" );
infile := TmpNameAllArchs();
cwsc := TmpNameAllArchs();
infile := TmpName();
cwsc := TmpName();

Check warning on line 404 in lib/codeman.gi

View check run for this annotation

Codecov / codecov/patch

lib/codeman.gi#L403-L404

Added lines #L403 - L404 were not covered by tests
PrintTo( infile, "\n" );
GuavaToLeon(C, incode);
Process(DirectoryCurrent(),
Expand Down
22 changes: 11 additions & 11 deletions lib/codeops.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1696,10 +1696,10 @@ function(C)
Print("... automatically switching to PermutationGroup ...\n");
return PermutationGroup(C);
fi;
incode := TmpNameAllArchs(); PrintTo( incode, "\n" );
inV := TmpNameAllArchs(); PrintTo( inV, "\n" );
outgroup := TmpNameAllArchs(); PrintTo( outgroup, "\n" );
infile := TmpNameAllArchs(); PrintTo( infile, "\n" );
incode := TmpName(); PrintTo( incode, "\n" );
inV := TmpName(); PrintTo( inV, "\n" );
outgroup := TmpName(); PrintTo( outgroup, "\n" );
infile := TmpName(); PrintTo( infile, "\n" );

Check warning on line 1702 in lib/codeops.gi

View check run for this annotation

Codecov / codecov/patch

lib/codeops.gi#L1699-L1702

Added lines #L1699 - L1702 were not covered by tests
# Calculate with dual code if it is smaller:
if Dimension(C) > QuoInt(WordLength(C), 2) then
Ccalc := DualCode(C);
Expand Down Expand Up @@ -2003,12 +2003,12 @@ function(C1, C2)
Error("GUAVA can only calculate equivalence over GF(2)");
fi;

code1 := TmpNameAllArchs(); PrintTo( code1, "\n" );
code2 := TmpNameAllArchs(); PrintTo( code2, "\n" );
cwcode1 := TmpNameAllArchs(); PrintTo( cwcode1, "\n" );
cwcode2 := TmpNameAllArchs(); PrintTo( cwcode2, "\n" );
output := TmpNameAllArchs(); PrintTo( output, "\n" );
infile := TmpNameAllArchs(); PrintTo( infile, "\n" );
code1 := TmpName(); PrintTo( code1, "\n" );
code2 := TmpName(); PrintTo( code2, "\n" );
cwcode1 := TmpName(); PrintTo( cwcode1, "\n" );
cwcode2 := TmpName(); PrintTo( cwcode2, "\n" );
output := TmpName(); PrintTo( output, "\n" );
infile := TmpName(); PrintTo( infile, "\n" );
GuavaToLeon(C1, code1);
GuavaToLeon(C2, code2);
#Exec(Filename(DirectoriesPackagePrograms("guava"), "wtdist"),
Expand Down Expand Up @@ -2754,7 +2754,7 @@ function(C)
k := DimensionsMat(G)[1];
n := DimensionsMat(G)[2];
#path := DirectoriesPackagePrograms( "guava" );; #seems unnecessary -- already done above...
tmpFile := TmpNameAllArchs(); tmpOutFile := TmpNameAllArchs();
tmpFile := TmpName(); tmpOutFile := TmpName();

Check warning on line 2757 in lib/codeops.gi

View check run for this annotation

Codecov / codecov/patch

lib/codeops.gi#L2757

Added line #L2757 was not covered by tests

PrintTo(tmpFile, k, " ", n, " ", Size(LeftActingDomain(C)), "\n");
for r in [1..k] do;
Expand Down

0 comments on commit 1343183

Please sign in to comment.