desauto: initialize the comment array to a sensible value #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If left uninitialized, the comment array is passed down to client code without being even written to, which means it contains whatever happens to be on the stack whenever the frame for `main` is created. Recent changes to glibc start code have changed said content, and the new one happens to break the test suite when propagated into some temporary files that are then fed to the main leonconv binary. That explains why using ThreadSanitizer "fixes" the test suite: presumably, the runtime initialization code happens to write in that aread of the stack and changes yet again the contents of the comment array, which happens to suit whatever expectations are in leonconv. Fixes gap-packages#98
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 44 44
Lines 14710 14710
Branches 203 203
=======================================
Hits 7245 7245
Misses 7465 7465 |
|
Simon, Thanks for discovering the issue and then finding a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If left uninitialized, the comment array is passed down to client code without being even written to, which means it contains whatever happens to be on the stack whenever the frame for
mainis created. Recent changes to glibc start code have changed said content, and the new one happens to break the test suite when propagated into some temporary files that are then fed to the main leonconv binary.That explains why using ThreadSanitizer "fixes" the test suite: presumably, the runtime initialization code happens to write in that aread of the stack and changes yet again the contents of the comment array, which happens to suit whatever expectations are in leonconv.
Fixes #98