Reapply #2329 - Gtk.ListView for Activity Parameters #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
changed the title
3 tasks
amolenaar
force-pushed
the
parameter-listview
branch
from
da5c76c
to
2f209d5
Compare
amolenaar
force-pushed
the
parameter-listview
branch
from
a0208cd
to
8845af2
Compare
amolenaar
force-pushed
the
parameter-listview
branch
2 times, most recently
from
473b75f
to
d9fed5c
Compare
This allows us to use the same text edit experience in the property editor.
amolenaar
force-pushed
the
parameter-listview
branch
from
d9fed5c
to
c1cdc3e
Compare
Instead of binding controllers programmatically.
By adding a little border
This moves more logic in the template, and less in our code.
amolenaar
force-pushed
the
parameter-listview
branch
from
6145228
to
3341f24
Compare
So it's more clear that a new parameter can be added.
3 tasks
danyeaw
added
feature
danyeaw
approved these changes
Dec 22, 2023
| """ | ||
|
|
||
|
|
||
| @Gtk.Template(string=_XML) |
There was a problem hiding this comment.
Is this our first use of Gtk.Template? Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
This PR should only be merged if we're sure it does not cause any crashes.
What is the current behavior?
The Activity Parameter property page had been reverted to
Gtk.TreeView, since theGtk.EditableLabelcaused the app to crash.Issue Number: #2433
What is the new behavior?
We want to get rid of deprecated API's.
Gtk.EditableLabelexposes some behavior that we currently have differently (e.g. the text should not change to editable state when a row is selected, only after a double click).We have a new widget:
TextField, that contains the text edit logic we use in the model browser. This widget looks more stable and works for the Parameter ListView too.Does this PR introduce a breaking change?
Other information
Added a placeholder text to the Parameter table, so it's more clear what a user can do in the box: