Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply #2329 - Gtk.ListView for Activity Parameters #2436

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 8, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

This PR should only be merged if we're sure it does not cause any crashes.

What is the current behavior?

The Activity Parameter property page had been reverted to Gtk.TreeView, since the Gtk.EditableLabel caused the app to crash.

Issue Number: #2433

What is the new behavior?

We want to get rid of deprecated API's.

Gtk.EditableLabel exposes some behavior that we currently have differently (e.g. the text should not change to editable state when a row is selected, only after a double click).

We have a new widget: TextField, that contains the text edit logic we use in the model browser. This widget looks more stable and works for the Parameter ListView too.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Added a placeholder text to the Parameter table, so it's more clear what a user can do in the box:

image

@amolenaar amolenaar marked this pull request as draft July 8, 2023 10:15
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 8, 2023
@amolenaar amolenaar changed the title Reapply #2434 - Gtk.ListView for Activity Parameters Reapply #2329 - Gtk.ListView for Activity Parameters Jul 8, 2023
@amolenaar amolenaar force-pushed the parameter-listview branch 2 times, most recently from 473b75f to d9fed5c Compare December 15, 2023 17:11
There should be a way to make this work safely.
This allows us to use the same text edit experience in
the property editor.
Instead of binding controllers programmatically.
By adding a little border
This moves more logic in the template, and less in our code.
@amolenaar amolenaar marked this pull request as ready for review December 18, 2023 18:05
So it's more clear that a new parameter can be added.
@amolenaar amolenaar mentioned this pull request Dec 21, 2023
3 tasks
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Dec 22, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new Parameter adder looks great @amolenaar!

"""


@Gtk.Template(string=_XML)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this our first use of Gtk.Template? Nice!

@danyeaw danyeaw merged commit 37fba44 into main Dec 22, 2023
20 checks passed
@danyeaw danyeaw deleted the parameter-listview branch December 22, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants